Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable TRY macro tests on MSVC #119

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Disable TRY macro tests on MSVC #119

merged 1 commit into from
Feb 15, 2024

Conversation

ChrisThrasher
Copy link
Collaborator

The TRY macro requires a GCC/Clang extension so we need to make sure we only compile those tests when GCC or Clang is being used.

Addresses part of but not all #116.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cebc67c) 98.65% compared to head (49cc1b3) 98.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files          11       11           
  Lines         223      223           
=======================================
  Hits          220      220           
  Misses          3        3           
Flag Coverage Δ
humble 98.65% <ø> (ø)
rolling 98.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisThrasher
Copy link
Collaborator Author

Can confirm the TRY tests are still being built and ran in CI.

@tylerjw tylerjw merged commit d55da72 into main Feb 15, 2024
37 checks passed
@delete-merged-branch delete-merged-branch bot deleted the windows_tests branch February 15, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants